LGTM with comments
http://codereview.chromium.org/2824007/diff/1/3 File test/cctest/test-debug.cc (right): http://codereview.chromium.org/2824007/diff/1/3#newcode2056 test/cctest/test-debug.cc:2056: { I will suggest that you just call function f and check that no break points are hit instead of looking up the break point. That will make your test independent of debugger internals. http://codereview.chromium.org/2824007/diff/1/3#newcode2078 test/cctest/test-debug.cc:2078: { Again it think that this should check that running the script caused one break point to be hit, and running f again will still not cause break points to be hit. http://codereview.chromium.org/2824007/diff/1/4 File test/mjsunit/debug-setbreakpoint.js (right): http://codereview.chromium.org/2824007/diff/1/4#newcode142 test/mjsunit/debug-setbreakpoint.js:142: eval('function sourceUrlFunc()\n{ a = 2; }\n//@ sourceURL=sourceUrlScript'); Why was this change required? http://codereview.chromium.org/2824007/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
