Reviewers: Mads Ager,

Description:
API: Resolve linker issues with using V8 as a DLL

This changes the way the constants kJSObjectType, kFirstNonstringType and
kProxyType are made available to the inlined part of the V8 API. This change to
fixed constants resolves linker this linker error Windows

error LNK2001: unresolved external symbol "public: static int
v8::internal::Internals::kJSObjectType"
(?kjsobjectt...@internals@inter...@v8@@2HA)

when linking against a V8 DLL.

This change also makes it possible to build all the C++ tests with
ENABLE_DEBUGGER_SUPPORT not defined. Now C++ tests run ENABLE_DEBUGGER_SUPPORT not defined, and only the JavaScript tests which tests the debugger fails when
ENABLE_DEBUGGER_SUPPORT is not defined.

Please review this at http://codereview.chromium.org/2820016/show

SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/

Affected files:
  M     include/v8.h
  M     src/api.cc
  M     src/objects.h
  M     test/cctest/test-api.cc
  M     test/cctest/test-debug.cc
  M     test/cctest/test-disasm-ia32.cc
  M     test/cctest/test-func-name-inference.cc
  M     test/cctest/test-liveedit.cc
  M     test/cctest/test-serialize.cc


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to