LGTM.
http://codereview.chromium.org/2814021/diff/1/2 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/2814021/diff/1/2#newcode10500 src/x64/codegen-x64.cc:10500: FloatingPointHelper::LoadAsIntegers(masm, We should probably add a specialized LoadNumbersAsIntegers, which knows that the inputs are smis or HeapNumbers. This would avoid some checks. http://codereview.chromium.org/2814021/diff/1/2#newcode10544 src/x64/codegen-x64.cc:10544: // Allocate heap number in new space. Comment that you are not using AllocateHeapNumber because you want to use the saved HeapNumber map. http://codereview.chromium.org/2814021/diff/1/2#newcode10601 src/x64/codegen-x64.cc:10601: // are already in rdx, rax. in rdx and rax. http://codereview.chromium.org/2814021/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
