http://codereview.chromium.org/2817018/diff/1/6 File src/compilation-cache.cc (right):
http://codereview.chromium.org/2817018/diff/1/6#newcode188 src/compilation-cache.cc:188: if (stats_table_ == NULL) { Since this round of changes is mostly mechanical, we try to not add caching variables like stats_table_ just yet, except glaringly obvious cases (like Heap::isolate_). Every such optimization should be done only if perf test shows benefit. It's better to keep Isolate::Current()->stats_table()-> form here. http://codereview.chromium.org/2817018/diff/1/6#newcode190 src/compilation-cache.cc:190: script_histogram_ = stats_table_->CreateHistogram( script_histogram seems to be a local variable, why did it move to be a class member? http://codereview.chromium.org/2817018/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
