There are some presubmit.py problems.
C:\Projects\v8.current\isolates\src\isolate.h:539: Do not use
variable-length
arrays. Use an appropriately named ('k' followed by CamelCase) compile-time
constant for the size. [runtime/arrays] [1]
Done processing isolate.h
top.cc:791: At least two spaces is best between code and comments
[whitespace/comments] [2]
top.h:0: No copyright message found. You should have a line: "Copyright
[year]
<Copyright Owner>" [legal/copyright] [5]
On 2010/06/21 16:39:43, Vitaly wrote:
LGTM
http://codereview.chromium.org/2866008/diff/74078/64017
File src/builtins.cc (right):
http://codereview.chromium.org/2866008/diff/74078/64017#newcode152
src/builtins.cc:152:
Isolate::Current()->c_entry_fp(Isolate::Current()->thread_local_top());
"c_entry_fp" is static.
http://codereview.chromium.org/2866008/diff/74078/64027
File src/frames.cc (right):
http://codereview.chromium.org/2866008/diff/74078/64027#newcode211
src/frames.cc:211: &&
Isolate::handler(Isolate::Current()->thread_local_top())
!= NULL),
nit: "&&" should be on the previous line.
http://codereview.chromium.org/2866008/diff/74078/64031
File src/handles.cc (right):
http://codereview.chromium.org/2866008/diff/74078/64031#newcode641
src/handles.cc:641: !Isolate::Current()->MayNamedAccess(*current,
HEAP->undefined_value(),
nit: Indent to line up with "c" on the previous line.
http://codereview.chromium.org/2866008/diff/74078/64041
File src/ic.cc (right):
http://codereview.chromium.org/2866008/diff/74078/64041#newcode85
src/ic.cc:85:
Isolate::Current()->c_entry_fp(Isolate::Current()->thread_local_top());
"c_entry_fp" is static.
http://codereview.chromium.org/2866008/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
