Reviewers: Søren Gjesse,
Description:
Make SampleRateCalculator test resilient to float precision issues.
Tested with kSamplingIntervalMs values 2 and 4.
Please review this at http://codereview.chromium.org/2811021/show
Affected files:
M test/cctest/test-profile-generator.cc
Index: test/cctest/test-profile-generator.cc
diff --git a/test/cctest/test-profile-generator.cc
b/test/cctest/test-profile-generator.cc
index
308f764ab4902ab84cd3a98e444391eb5715da57..b0a9b8e71544c47072c17703331a3cc75e52af8f
100644
--- a/test/cctest/test-profile-generator.cc
+++ b/test/cctest/test-profile-generator.cc
@@ -653,7 +653,7 @@ TEST(SampleRateCalculator) {
time += SampleRateCalculator::kWallTimeQueryIntervalMs * 0.75;
calc2.UpdateMeasurements(time);
// (1.0 + 2.0 + 2.0) / 3
- CHECK_EQ(kSamplingIntervalMs * 1.66666, calc2.ticks_per_ms());
+ CHECK_EQ(kSamplingIntervalMs * 5.0, round(calc2.ticks_per_ms() * 3.0));
SampleRateCalculator calc3;
time = 0.0;
@@ -667,7 +667,7 @@ TEST(SampleRateCalculator) {
time += SampleRateCalculator::kWallTimeQueryIntervalMs * 1.5;
calc3.UpdateMeasurements(time);
// (1.0 + 0.5 + 0.5) / 3
- CHECK_EQ(kSamplingIntervalMs * 0.66666, calc3.ticks_per_ms());
+ CHECK_EQ(kSamplingIntervalMs * 2.0, round(calc3.ticks_per_ms() * 3.0));
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
