LGTM!
http://codereview.chromium.org/2801007/diff/5001/6002 File src/arm/ic-arm.cc (right): http://codereview.chromium.org/2801007/diff/5001/6002#newcode53 src/arm/ic-arm.cc:53: Label* miss) { miss -> global_object? http://codereview.chromium.org/2801007/diff/5001/6002#newcode65 src/arm/ic-arm.cc:65: // Generated code falls through if the receiver is a regular JS object regular -> regular non-global http://codereview.chromium.org/2801007/diff/5001/6002#newcode98 src/arm/ic-arm.cc:98: __ b(ne, miss); You could you nz here (which is the same as ne so it only matters for readability). http://codereview.chromium.org/2801007/diff/5001/6002#newcode126 src/arm/ic-arm.cc:126: Register t0, Change name back to scratch for these? http://codereview.chromium.org/2801007/diff/5001/6002#newcode130 src/arm/ic-arm.cc:130: // dictionary. Indentation or change name of registers back to scratch. http://codereview.chromium.org/2801007/diff/5001/6002#newcode347 src/arm/ic-arm.cc:347: __ b(ne, slow); Could use nz. http://codereview.chromium.org/2801007/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
