http://codereview.chromium.org/2841023/diff/21002/34021 File src/log.cc (right):
http://codereview.chromium.org/2841023/diff/21002/34021#newcode311 src/log.cc:311: if (Logger::profiler_) { This seems strange. Logger::profiler_ is initialized with a Profiler instance. That means, instead of Logger::profiler_, we can just use 'this' here. I'll check this out. http://codereview.chromium.org/2841023/diff/21002/34021#newcode1155 src/log.cc:1155: if (profiler_ && !profiler_->paused()) { The 3 checks below are indeed needed, thanks! This is because methods can be called via API, and if there were no '--prof' flag, profiler_ can be NULL. But please use explicit check: profiler_ != NULL http://codereview.chromium.org/2841023/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
