LGTM.
http://codereview.chromium.org/2815028/diff/1/6 File src/x64/virtual-frame-x64.cc (right): http://codereview.chromium.org/2815028/diff/1/6#newcode119 src/x64/virtual-frame-x64.cc:119: // For less locals the unrolled loop is more compact. For fewer locals http://codereview.chromium.org/2815028/diff/1/6#newcode124 src/x64/virtual-frame-x64.cc:124: ASSERT(tmp.is_valid()); If this does not work, is it worth copying rax to kScratchRegister, then using rax for the pushes? http://codereview.chromium.org/2815028/diff/1/6#newcode141 src/x64/virtual-frame-x64.cc:141: __ movb(cnt.reg(), Immediate(count)); Doesn't movb leave the upper bits unchanged? We need to clear them. Oh, I see you are using decb. Put a comment saying this. Doesn't this introduce partial register dependencies? I'm not sure this is worth it. http://codereview.chromium.org/2815028/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
