http://codereview.chromium.org/2868018/diff/14001/15002 File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/2868018/diff/14001/15002#newcode900 src/arm/codegen-arm.cc:900: if ((stub.runtime_operands_type() != BinaryOpIC::HEAP_NUMBERS) && Checking the runtime operand type doesn't make sense here. A newly created GenericBinaryOpStub always has a type of 'DEFAULT'. http://codereview.chromium.org/2868018/diff/14001/15002#newcode937 src/arm/codegen-arm.cc:937: __ set_branch_target_at(done_inline_mul, The implementation of set_branch_target_at seems to be missing from the uploaded code. But you don't need it anyway. You need two JumpTargets, slow and done. The slow one is bound where you have done being bound now and done is bound at the bottom where the result is in r0. http://codereview.chromium.org/2868018/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
