[v8-dev] Re: Ensure that ToPrimitive is called on all objects involved in comparisons <, <... (issue2834022)

Thu, 24 Jun 2010 08:39:47 -0700 

LGTM with a test added (either in this changelist or as a separate follow-up
changelist).


http://codereview.chromium.org/2834022/diff/1/2
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/2834022/diff/1/2#newcode11698
src/ia32/codegen-ia32.cc:11698: __ j(not_equal, &not_identical);
Could you add a comment here as in the x64 version?

http://codereview.chromium.org/2834022/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to