Reviewers: Rico, Description: Fix bug in JSON.stringify where Boolean objects are incorrectly unwrapped.
This fixes issue 752. Please review this at http://codereview.chromium.org/2845023/show SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/json.js A test/mjsunit/regress/regress-752.js Index: src/json.js =================================================================== --- src/json.js (revision 4945) +++ src/json.js (working copy) @@ -207,7 +207,7 @@ } else if (IS_STRING_WRAPPER(value)) { value = $String(value); } else if (IS_BOOLEAN_WRAPPER(value)) { - value = $Boolean(value); + value = %_ValueOf(value); } } switch (typeof value) { Index: test/mjsunit/regress/regress-752.js =================================================================== --- test/mjsunit/regress/regress-752.js (revision 0) +++ test/mjsunit/regress/regress-752.js (revision 0) @@ -0,0 +1,36 @@ +// Copyright 2010 the V8 project authors. All rights reserved. +// Redistribution and use in source and binary forms, with or without +// modification, are permitted provided that the following conditions are +// met: +// +// * Redistributions of source code must retain the above copyright +// notice, this list of conditions and the following disclaimer. +// * Redistributions in binary form must reproduce the above +// copyright notice, this list of conditions and the following +// disclaimer in the documentation and/or other materials provided +// with the distribution. +// * Neither the name of Google Inc. nor the names of its +// contributors may be used to endorse or promote products derived +// from this software without specific prior written permission. +// +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +// Test that JSON.stringify correctly unwraps Boolean objects. + +// See: http://code.google.com/p/v8/issues/detail?id=752 + +function replacer(key, value) { + return value === 42 ? new Boolean(false) : value; +} + +assertEquals(JSON.stringify([42], replacer), "[false]"); -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
