LGTM
http://codereview.chromium.org/2840021/diff/1/2 File src/array.js (right): http://codereview.chromium.org/2840021/diff/1/2#newcode957 src/array.js:957: if (index == null) { Use if (IS_UNDEFINED(index)) { instead. It'll catch the case where there is only on argument just as well, but won't waste time comparing to null. http://codereview.chromium.org/2840021/diff/1/3 File test/mjsunit/regress/regress-754.js (right): http://codereview.chromium.org/2840021/diff/1/3#newcode37 test/mjsunit/regress/regress-754.js:37: assertEquals(a.lastIndexOf(2, null), -1); Add the cases with only one argument as well. Put expected value as first arguemtn to assertEquals, and actual as second. Always give a third argument to assertEquals, so you can see which test failed (if the expected values aren't unique in the file). They don't have to be fancy or saying, just unique and searchable. http://codereview.chromium.org/2840021/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
