LGTM

http://codereview.chromium.org/2811033/diff/1/7
File src/isolate.h (right):

http://codereview.chromium.org/2811033/diff/1/7#newcode181
src/isolate.h:181: V(int, jsregexp_static_offsets_vector,
kJsRegexpStaticOffsetsVectorSize)
nit: s/Js/JS

http://codereview.chromium.org/2811033/diff/1/7#newcode199
src/isolate.h:199: V(unsigned, code_entry_next_call_uid, NULL)
                       \
Needs a comment.

http://codereview.chromium.org/2811033/diff/1/7#newcode575
src/isolate.h:575: static const int kJsRegexpStaticOffsetsVectorSize =
50;
nit: s/Js/JS

http://codereview.chromium.org/2811033/diff/1/11
File src/objects.cc (right):

http://codereview.chromium.org/2811033/diff/1/11#newcode4663
src/objects.cc:4663: static inline bool
CompareStringContentsPartial(Isolate* isolate, IteratorA* ia,
nit: Please reformat to have one arg per line.

http://codereview.chromium.org/2811033/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to