On 2010/06/25 22:26:28, Vitaly wrote:
LGTM.
http://codereview.chromium.org/2840018/diff/60003/64049
File src/runtime.h (right):
http://codereview.chromium.org/2840018/diff/60003/64049#newcode602
src/runtime.h:602: class InlineRuntimeFunctionsTable {
Even though it has "Runtime" in its name it's really a part of the code
generator. Please move it to codegen.h (if possible). Also consider moving
lookup/patching functions from the code generator to this class.
I tried this while I was building the patch-- but the compiler becomes very
upset when isolate.h begins to depend on codegen.h, and I think that doing
the
inlining is important. (I can try to change this in another, smaller patch
if it
turns out to be really unpalatable.)
Thanks again!
http://codereview.chromium.org/2840018/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
