LGTM
http://codereview.chromium.org/2876011/diff/1/2 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/2876011/diff/1/2#newcode6266 src/arm/codegen-arm.cc:6266: void DigitSum(MacroAssembler* masm, static (times 5)? And why are these functions not just private members of the IntegerModStub? http://codereview.chromium.org/2876011/diff/1/8 File test/mjsunit/mod.js (right): http://codereview.chromium.org/2876011/diff/1/8#newcode31 test/mjsunit/mod.js:31: m = i % j; This kind of assumes that -((-i) % j) is not handled by the new code. Currently it isn't, but it might be extended to do that. How about adding a %TestModulus to runtime.cc which just calls fmod instead? http://codereview.chromium.org/2876011/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
