Please address these comments and I'll land.
Thanks, Vitaly http://codereview.chromium.org/2844034/diff/1/6 File src/ast.cc (right): http://codereview.chromium.org/2844034/diff/1/6#newcode94 src/ast.cc:94: var_(NULL), Member initialization order should match the declaration order. Please move var_ initialization to be the first. http://codereview.chromium.org/2844034/diff/1/2 File src/builtins.cc (right): http://codereview.chromium.org/2844034/diff/1/2#newcode1382 src/builtins.cc:1382: Builtins::Builtins(): initialized_(false) { nit: Space before ":". http://codereview.chromium.org/2844034/diff/1/3 File src/isolate.h (right): http://codereview.chromium.org/2844034/diff/1/3#newcode250 src/isolate.h:250: // Destroy the global isolate and create a new one in its place. The comment needs to be updated. http://codereview.chromium.org/2844034/diff/1/7 File src/version.cc (right): http://codereview.chromium.org/2844034/diff/1/7#newcode39 src/version.cc:39: #define CANDIDATE_VERSION 1 Document that "1" should be used for candidate versions and "0" otherwise. http://codereview.chromium.org/2844034/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
