LGTM.
Thanks a lot for fixing this! I'm afraid I broke it in r4894:
bool String::IsAsciiRepresentation() {
uint32_t type = map()->instance_type();
- if ((type & kStringRepresentationMask) == kConsStringTag &&
- ConsString::cast(this)->second()->length() == 0) {
- return ConsString::cast(this)->first()->IsAsciiRepresentation();
- }
return (type & kStringEncodingMask) == kAsciiStringTag;
}
-- Vitaly
http://codereview.chromium.org/2858033/diff/1/5
File test/cctest/test-api.cc (right):
http://codereview.chromium.org/2858033/diff/1/5#newcode10980
test/cctest/test-api.cc:10980: i::String::cast(string->TryFlatten());
TryFlattenGetString returns the right string and requires no casting.
http://codereview.chromium.org/2858033/diff/1/5#newcode10985
test/cctest/test-api.cc:10985: uint16_t *uc16_buffer = new
uint16_t[length + 1];
nit: Wrong placement of "*".
http://codereview.chromium.org/2858033/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
