LGTM.
http://codereview.chromium.org/2864026/diff/20001/21001 File src/api.cc (right): http://codereview.chromium.org/2864026/diff/20001/21001#newcode4084 src/api.cc:4084: if (isolate->debug_event_callback()) { nit: Please use explicit "!= NULL". http://codereview.chromium.org/2864026/diff/20001/21002 File src/arm/assembler-arm-inl.h (right): http://codereview.chromium.org/2864026/diff/20001/21002#newcode182 src/arm/assembler-arm-inl.h:182: } else if (Isolate::Current()->debug()->has_break_points() && We should really get a cached isolate instance here (add a todo). Until then has_break_points() should be moved past the other checks in the sequence of &&'s since it became slower. http://codereview.chromium.org/2864026/diff/20001/21005 File src/bootstrapper.cc (right): http://codereview.chromium.org/2864026/diff/20001/21005#newcode1447 src/bootstrapper.cc:1447: Isolate* isolate = Isolate::Current(); It makes more sense to cache the debug object instead. http://codereview.chromium.org/2864026/diff/20001/21006 File src/debug.cc (right): http://codereview.chromium.org/2864026/diff/20001/21006#newcode698 src/debug.cc:698: Isolate* isolate = Isolate::Current(); Ditto. http://codereview.chromium.org/2864026/diff/20001/21006#newcode877 src/debug.cc:877: // This remains a static method so that the runtime can call to it. "so that the generated code can call" http://codereview.chromium.org/2864026/diff/20001/21010 File src/ia32/assembler-ia32-inl.h (right): http://codereview.chromium.org/2864026/diff/20001/21010#newcode172 src/ia32/assembler-ia32-inl.h:172: } else if (Isolate::Current()->debug()->has_break_points() && See above. http://codereview.chromium.org/2864026/diff/20001/21011 File src/ia32/debug-ia32.cc (right): http://codereview.chromium.org/2864026/diff/20001/21011#newcode82 src/ia32/debug-ia32.cc:82: Isolate* isolate = Isolate::Current(); nit: Indent. http://codereview.chromium.org/2864026/diff/20001/21013 File src/ic.cc (right): http://codereview.chromium.org/2864026/diff/20001/21013#newcode482 src/ic.cc:482: Isolate* isolate = Isolate::Current(); See above. http://codereview.chromium.org/2864026/diff/20001/21016 File src/liveedit.cc (right): http://codereview.chromium.org/2864026/diff/20001/21016#newcode1259 src/liveedit.cc:1259: Isolate* isolate = Isolate::Current(); See above (debug). http://codereview.chromium.org/2864026/diff/20001/21017 File src/objects.cc (right): http://codereview.chromium.org/2864026/diff/20001/21017#newcode202 src/objects.cc:202: Isolate* isolate = Isolate::Current(); Ditto. http://codereview.chromium.org/2864026/diff/20001/21017#newcode1641 src/objects.cc:1641: Isolate* isolate = Isolate::Current(); Ditto. http://codereview.chromium.org/2864026/diff/20001/21018 File src/runtime.cc (right): http://codereview.chromium.org/2864026/diff/20001/21018#newcode6624 src/runtime.cc:6624: Isolate* isolate = Isolate::Current(); Ditto. http://codereview.chromium.org/2864026/diff/20001/21022 File src/x64/assembler-x64-inl.h (right): http://codereview.chromium.org/2864026/diff/20001/21022#newcode347 src/x64/assembler-x64-inl.h:347: } else if (Isolate::Current()->debug()->has_break_points() && See above. http://codereview.chromium.org/2864026/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
