LGTM.
http://codereview.chromium.org/2812031/diff/16001/17011 File src/heap.h (right): http://codereview.chromium.org/2812031/diff/16001/17011#newcode235 src/heap.h:235: public: Please add default constructor that initialized the fields to avoid reading garbage. http://codereview.chromium.org/2812031/diff/16001/17011#newcode255 src/heap.h:255: }; DISALLOW_COPY_AND_ASSIGN http://codereview.chromium.org/2812031/diff/16001/17016 File src/isolate.h (right): http://codereview.chromium.org/2812031/diff/16001/17016#newcode648 src/isolate.h:648: unibrow::Mapping<unibrow::Ecma262Canonicalize>* interp_canonicalize() { "canonicalize_mapping"? http://codereview.chromium.org/2812031/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
