LGTM
http://codereview.chromium.org/2819034/diff/1/4 File src/objects.cc (right): http://codereview.chromium.org/2819034/diff/1/4#newcode2585 src/objects.cc:2585: // If there is fast elements we normalize. is -> are http://codereview.chromium.org/2819034/diff/1/4#newcode2596 src/objects.cc:2596: Map::cast(new_map)->set_is_extensible(false); This is going to make a lot of maps. We need a set of slow maps (one for each flag combination) and then just pick the right one. This will benefit other parts of the system too. No need to put it in this change though. http://codereview.chromium.org/2819034/diff/1/4#newcode6237 src/objects.cc:6237: // the object into dictionary mode (and force it to stay there). Not the whole object, just the elements, right? http://codereview.chromium.org/2819034/diff/1/8 File src/v8natives.js (right): http://codereview.chromium.org/2819034/diff/1/8#newcode762 src/v8natives.js:762: !IS_UNDETECTABLE(obj)) { You can't even ask an undetectable object whether it is extensible? Deep undercover... http://codereview.chromium.org/2819034/diff/1/10 File test/mjsunit/object-prevent-extensions.js (right): http://codereview.chromium.org/2819034/diff/1/10#newcode115 test/mjsunit/object-prevent-extensions.js:115: assertUnreachable We don't allow semicolons to be omitted. http://codereview.chromium.org/2819034/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
