LGTM
http://codereview.chromium.org/2830026/diff/4003/37 File src/bootstrapper.h (right): http://codereview.chromium.org/2830026/diff/4003/37#newcode52 src/bootstrapper.h:52: nit: Just one blank line between class members. http://codereview.chromium.org/2830026/diff/4003/37#newcode66 src/bootstrapper.h:66: Ditto. http://codereview.chromium.org/2830026/diff/4003/52 File src/isolate.h (right): http://codereview.chromium.org/2830026/diff/4003/52#newcode272 src/isolate.h:272: V(CodeGenerator*, code_generator_scope_top, NULL) \ Maybe just "current_code_generator"? http://codereview.chromium.org/2830026/diff/4003/52#newcode980 src/isolate.h:980: #include "allocation-inl.h" Ugh, this is ugly. Please a TODO to get rid of this. We should just add these includes where they are needed. http://codereview.chromium.org/2830026/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
