On 2010/07/01 20:53:23, Vitaly wrote:
What about adding a similar mutex to platform-win32?
http://codereview.chromium.org/2807031/diff/16001/17010
File src/regexp-stack.h (right):
http://codereview.chromium.org/2807031/diff/16001/17010#newcode41
src/regexp-stack.h:41: class RegExpStack {
The usage pattern of these two classes suggests other naming:
RegExpStackScope
and RegExpStack.
http://codereview.chromium.org/2807031/diff/16001/17010#newcode48
src/regexp-stack.h:48:
It might make sense to expose an accessor to the current stack. Then we
can
write code like this:
RegExpStackScope re_scope(isolate);
Foo(re_scope.stack()->stack_base())
http://codereview.chromium.org/2807031/diff/16001/17010#newcode51
src/regexp-stack.h:51: };
DISALLOW_COPY_AND_ASSIGN
I think I hit these; thanks for the feedback!
http://codereview.chromium.org/2807031/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
