LGTM

http://codereview.chromium.org/2800044/diff/1/2
File src/heap.cc (right):

http://codereview.chromium.org/2800044/diff/1/2#newcode2354
src/heap.cc:2354: Object* reloc_info =
AllocateByteArray(desc.reloc_size, TENURED);
Please add a note that this mustn't be put in the middle of code object
creation because leaving an uninitialized code object (no map and sizes)
breaks the code space.

http://codereview.chromium.org/2800044/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to