LGTM

http://codereview.chromium.org/2982001/diff/17001/18001
File src/arm/stub-cache-arm.cc (right):

http://codereview.chromium.org/2982001/diff/17001/18001#newcode95
src/arm/stub-cache-arm.cc:95: Register r0,
Since this is ARM I find the r0 and r1 names confusing (since they are
names of real registers). If they are scratch registers could you use
scratch0 and scratch1 or something like that? Or give them other telling
names?

http://codereview.chromium.org/2982001/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to