http://codereview.chromium.org/2962007/diff/7001/9 File include/v8-debug.h (right):
http://codereview.chromium.org/2962007/diff/7001/9#newcode263 include/v8-debug.h:263: static void DebugBreakForCommand(ClientData* data = NULL); On 2010/07/13 09:50:42, Yury Semikhatsky wrote:
You will end up processing a series of indistinguishable
BreakForCommand events
if you call DebugBreakForCommand several times in row with NULL
argument. But
probably that's fine.
That may have sense to a client, so why not? http://codereview.chromium.org/2962007/diff/7001/11 File src/debug.cc (right): http://codereview.chromium.org/2962007/diff/7001/11#newcode2234 src/debug.cc:2234: if (event == v8::Break) { On 2010/07/13 09:50:42, Yury Semikhatsky wrote:
This command will be processed in NotifyMessageHandler above if there
is a
message_handler_. I'd recommend you use separate queue that would
store
DebugBreak requests.
OK, introduced a separate queue. http://codereview.chromium.org/2962007/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
