Reviewers: Mads Ager,

Message:
Hi Mads

Can I ask you to take a look at this CL. Soren is out of office same as Vitaly.

This change modifies ScopeInfo, but is should behave exactly the same until
liveedit is actually used.

I am disposing old stack manipulation code and replace it with a better one. It remove 1+ frames, but the bottom (js) frame gets restarted. I add a small patch
to the code of function and reset the scope on stack. Hope that's enough.

Peter

Description:
Reimplement stack manipulations for LiveEdit

Overview:
When function gets updated with a new code, it may stay activated on stack and have to be restarted. The code of the function is additionally patched with a
'restarter' code snippet and PC is set there.

All scope analyzers must realize that there are no local variables in this
state.

Please review this at http://codereview.chromium.org/2943002/show

Affected files:
  M src/arm/debug-arm.cc
  M src/builtins.h
  M src/builtins.cc
  M src/debug.h
  M src/debug.cc
  M src/factory.h
  M src/factory.cc
  M src/frames.h
  M src/frames.cc
  M src/heap.h
  M src/heap.cc
  M src/ia32/debug-ia32.cc
  M src/liveedit-debugger.js
  M src/liveedit.h
  M src/liveedit.cc
  M src/mips/debug-mips.cc
  M src/profile-generator.cc
  M src/runtime.h
  M src/runtime.cc
  M src/scopeinfo.h
  M src/scopeinfo.cc
  M src/x64/debug-x64.cc


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to