LGTM Return statement comments below apply to x64 as well.
http://codereview.chromium.org/2897013/diff/1/2 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/2897013/diff/1/2#newcode2806 src/ia32/codegen-ia32.cc:2806: return; I think I would prefer an else instead of the return here. http://codereview.chromium.org/2897013/diff/1/2#newcode2840 src/ia32/codegen-ia32.cc:2840: return; And here as well. http://codereview.chromium.org/2897013/diff/1/2#newcode2878 src/ia32/codegen-ia32.cc:2878: not_number.Branch(not_equal, left_side); Indentation is off from here. http://codereview.chromium.org/2897013/diff/1/3 File src/ia32/codegen-ia32.h (right): http://codereview.chromium.org/2897013/diff/1/3#newcode563 src/ia32/codegen-ia32.h:563: // If at least one of the sides is a constant smi, generate optimized code. Could you add a blank line before the comment. http://codereview.chromium.org/2897013/diff/1/5 File src/x64/codegen-x64.h (right): http://codereview.chromium.org/2897013/diff/1/5#newcode524 src/x64/codegen-x64.h:524: // If at least one of the sides is a constant smi, generate optimized code. Could you add a blank line before the comment? http://codereview.chromium.org/2897013/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
