Reviewers: Mads Ager,
Description:
Add direct_dependent_settings for v8 dll so targets depends on v8 has
USING_V8_SHARED defined.
Please review this at http://codereview.chromium.org/2946014/show
SVN Base: http://v8.googlecode.com/svn/trunk/
Affected files:
M tools/gyp/v8.gyp
Index: tools/gyp/v8.gyp
===================================================================
--- tools/gyp/v8.gyp (revision 5033)
+++ tools/gyp/v8.gyp (working copy)
@@ -181,6 +181,11 @@
'defines': [
'BUILDING_V8_SHARED'
],
+ 'direct_dependent_settings': {
+ 'defines': [
+ 'USING_V8_SHARED',
+ ],
+ },
},
{
'type': 'none',
@@ -738,11 +743,6 @@
# This could be gotten by not setting chromium_code, if that's
OK.
'defines': ['_CRT_SECURE_NO_WARNINGS'],
}],
- ['OS=="win" and component=="shared_library"', {
- 'defines': [
- 'USING_V8_SHARED',
- ],
- }],
],
},
],
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
