Reviewers: Rico,
Message:
It looks like they fixed the Operand(rax) error already, as part of the
earlier
merge, and didn't include it in the description (or fix it in
bleeding-edge).
So now it is changed from their fix to my fix.
Description:
[isolates] Merge 5083:5084 into isolates branch. Fix compiler errors on
x64.
Please review this at http://codereview.chromium.org/2878034/show
SVN Base: http://v8.googlecode.com/svn/branches/experimental/isolates/
Affected files:
M src/profile-generator.cc
M src/x64/codegen-x64.cc
Index: src/profile-generator.cc
===================================================================
--- src/profile-generator.cc (revision 5083)
+++ src/profile-generator.cc (working copy)
@@ -1559,7 +1559,8 @@
uint64_t HeapObjectsMap::FindEntry(Address addr) {
HashMap::Entry* entry = entries_map_.Lookup(addr, AddressHash(addr),
false);
if (entry != NULL) {
- int entry_index = reinterpret_cast<intptr_t>(entry->value);
+ int entry_index =
+ static_cast<int>(reinterpret_cast<intptr_t>(entry->value));
EntryInfo& entry_info = entries_->at(entry_index);
entry_info.accessed = true;
return entry_info.id;
@@ -1574,7 +1575,8 @@
for (HashMap::Entry* entry = entries_map_.Start();
entry != NULL;
entry = entries_map_.Next(entry)) {
- int entry_index = reinterpret_cast<intptr_t>(entry->value);
+ int entry_index =
+ static_cast<int>(reinterpret_cast<intptr_t>(entry->value));
EntryInfo& entry_info = entries_->at(entry_index);
if (entry_info.accessed) {
entry->value = reinterpret_cast<void*>(new_entries->length());
Index: src/x64/codegen-x64.cc
===================================================================
--- src/x64/codegen-x64.cc (revision 5083)
+++ src/x64/codegen-x64.cc (working copy)
@@ -438,7 +438,7 @@
default:
UNREACHABLE();
- return Operand(rax, 0);
+ return Operand(rsp, 0);
}
}
@@ -11537,7 +11537,7 @@
// Make count the number of bytes to copy.
if (!ascii) {
- ASSERT_EQ(2, sizeof(uc16)); // NOLINT
+ ASSERT_EQ(2, static_cast<int>(sizeof(uc16))); // NOLINT
__ addl(count, count);
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
