LGTM, if comments are addressed.
http://codereview.chromium.org/2877018/diff/35001/1016 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/2877018/diff/35001/1016#newcode4767 src/arm/codegen-arm.cc:4767: // It includes undetectable objects (as oppose to IsObject). as opposed to or // It includes undetectable objects (IsObject does not). http://codereview.chromium.org/2877018/diff/35001/1022 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/2877018/diff/35001/1022#newcode6456 src/ia32/codegen-ia32.cc:6456: temp.Unuse(); temp is not declared in this function. You cannot use value.reg() as a temp register unless you spill it from the frame. Otherwise, it might be shared by another local variable. http://codereview.chromium.org/2877018/diff/35001/1028 File src/runtime.js (right): http://codereview.chromium.org/2877018/diff/35001/1028#newcode588 src/runtime.js:588: if (IS_SPEC_OBJECT(x)) return false; Why not return !IS_SPEC_OBJECT(x); ? http://codereview.chromium.org/2877018/diff/35001/1030 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/2877018/diff/35001/1030#newcode5739 src/x64/codegen-x64.cc:5739: __ CmpObjectType(value.reg(), FIRST_JS_OBJECT_TYPE, value.reg); kScratchRegister can be used here. http://codereview.chromium.org/2877018/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
