LGTM, nice catch! A single naming suggestion:
http://codereview.chromium.org/3028006/diff/1/2 File src/d8.cc (right): http://codereview.chromium.org/3028006/diff/1/2#newcode448 src/d8.cc:448: i::Debug* debug_object = i::Isolate::Current()->debug(); Everywhere else this is named just 'debug' rather then 'debug_object'. http://codereview.chromium.org/3028006/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
