LGTM
http://codereview.chromium.org/3011009/diff/1/2 File include/v8.h (right): http://codereview.chromium.org/3011009/diff/1/2#newcode140 include/v8.h:140: * This callback should either explicitly |Dispose| |object| if V8 wrapper |Dispose| |object| -> invoke Dispose on |object|? |MakeWeak| -> MakeWeak? http://codereview.chromium.org/3011009/diff/1/3 File src/global-handles.cc (right): http://codereview.chromium.org/3011009/diff/1/3#newcode182 src/global-handles.cc:182: ASSERT(state_ != NEAR_DEATH); // Absense of explicit cleanup or revival Please move the comment to the line before the assert. http://codereview.chromium.org/3011009/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
