Revision: 5099
Author: [email protected]
Date: Mon Jul 19 22:51:10 2010
Log: Land for Victor Wang.
Add direct_dependent_settings for v8 dll so targets that depend on v8
has USING_V8_SHARED defined.
Review URL: http://codereview.chromium.org/2946014/show
http://code.google.com/p/v8/source/detail?r=5099
Modified:
/branches/bleeding_edge/tools/gyp/v8.gyp
=======================================
--- /branches/bleeding_edge/tools/gyp/v8.gyp Fri Jul 2 00:39:42 2010
+++ /branches/bleeding_edge/tools/gyp/v8.gyp Mon Jul 19 22:51:10 2010
@@ -181,6 +181,11 @@
'defines': [
'BUILDING_V8_SHARED'
],
+ 'direct_dependent_settings': {
+ 'defines': [
+ 'USING_V8_SHARED',
+ ],
+ },
},
{
'type': 'none',
@@ -738,11 +743,6 @@
# This could be gotten by not setting chromium_code, if that's
OK.
'defines': ['_CRT_SECURE_NO_WARNINGS'],
}],
- ['OS=="win" and component=="shared_library"', {
- 'defines': [
- 'USING_V8_SHARED',
- ],
- }],
],
},
],
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev