Please remember to build and test in debug mode as well.

Fixed compilation issues and landed as bleeding_edge revision 5106.

Thanks for the patch!


http://codereview.chromium.org/3036008/diff/1/6
File src/arm/macro-assembler-arm.cc (right):

http://codereview.chromium.org/3036008/diff/1/6#newcode287
src/arm/macro-assembler-arm.cc:287: ASSERT(!dst.is(pc) &&
!src.rm_.is(pc));
rm_ is private

http://codereview.chromium.org/3036008/diff/1/6#newcode292
src/arm/macro-assembler-arm.cc:292: ASSERT((src.shift_op_ == ASR) ||
(src.shift_op_ == LSL));
shift_op_ is private

http://codereview.chromium.org/3036008/diff/1/6#newcode293
src/arm/macro-assembler-arm.cc:293: ASSERT(src.rs_.is(no_reg));
rs_ is private

http://codereview.chromium.org/3036008/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to