http://codereview.chromium.org/3008017/diff/10001/11003 File src/x64/codegen-x64.cc (right):
http://codereview.chromium.org/3008017/diff/10001/11003#newcode8029 src/x64/codegen-x64.cc:8029: __ Move(kScratchRegister, Factory::null_value()); On 2010/07/21 16:06:45, William Hesse wrote:
Should you avoid using __ between patch_site and moving the map to kScratchRegister?
I probably should. I don't think the code coverage support is working at the moment but no reason to break it on purpose. :) Thanks. Done. http://codereview.chromium.org/3008017/diff/10001/11004 File src/x64/ic-x64.cc (right): http://codereview.chromium.org/3008017/diff/10001/11004#newcode1756 src/x64/ic-x64.cc:1756: int encoded_offsets = *reinterpret_cast<int*>(encoded_offsets_address); On 2010/07/21 16:06:45, William Hesse wrote:
Should you use int32_t here? We have never asserted that int is 32
bits, I
think.
There is a lot of code that uses the knowledge that int is 32-bit on x64 already. This is following the style used in the rest of the patching code. http://codereview.chromium.org/3008017/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
