http://codereview.chromium.org/3017018/diff/1/2 File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/3017018/diff/1/2#newcode818 src/arm/codegen-arm.cc:818: STATIC_ASSERT(0 == kSmiTag); sometimes you have == 0 sometimes 0 == please make it consistent. http://codereview.chromium.org/3017018/diff/1/2#newcode9841 src/arm/codegen-arm.cc:9841: STATIC_ASSERT(0 == kStringTag | kSeqStringTag); predence problem http://codereview.chromium.org/3017018/diff/1/2#newcode9851 src/arm/codegen-arm.cc:9851: STATIC_ASSERT(kExternalStringTag !=0); space after != http://codereview.chromium.org/3017018/diff/1/3 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/3017018/diff/1/3#newcode11459 src/ia32/codegen-ia32.cc:11459: STATIC_ASSERT(0 == kStringTag | kSeqStringTag | kTwoByteStringTag); precedence http://codereview.chromium.org/3017018/diff/1/3#newcode11471 src/ia32/codegen-ia32.cc:11471: STATIC_ASSERT(kExternalStringTag !=0); space after != http://codereview.chromium.org/3017018/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
