I would also go for a context specific cache to limit the number of collisions.

I don't know if all of the xors in the hash function makes sense. Maybe we can
make it simpler and still get something decent.


http://codereview.chromium.org/3028019/diff/1/4
File src/objects.cc (right):

http://codereview.chromium.org/3028019/diff/1/4#newcode2117
src/objects.cc:2117: class NormalizedMapCache {
: public AllStatic ?

Also, please have public: section before private:.

http://codereview.chromium.org/3028019/diff/1/4#newcode2154
src/objects.cc:2154: return index & 0xFF;
Why do you return only 8 bits?

http://codereview.chromium.org/3028019/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to