Reviewers: Mads Ager,

Message:
Mads,

may you have a look?

presubmit and ia32 tests pass.

Description:
Backport http://code.google.com/p/v8/source/detail?r=5120 to 2.2.


Please review this at http://codereview.chromium.org/2861077/show

SVN Base: http://v8.googlecode.com/svn/branches/2.2/

Affected files:
  M     src/objects.cc


Index: src/objects.cc
===================================================================
--- src/objects.cc      (revision 5129)
+++ src/objects.cc      (working copy)
@@ -2966,7 +2966,8 @@
         break;
     }

-    SetElementCallback(index, info, info->property_attributes());
+ Object* ok = SetElementCallback(index, info, info->property_attributes());
+    if (ok->IsFailure()) return ok;
   } else {
     // Lookup the name.
     LookupResult result;
@@ -2976,7 +2977,8 @@
if (result.IsProperty() && (result.IsReadOnly() || result.IsDontDelete())) {
       return Heap::undefined_value();
     }
-    SetPropertyCallback(name, info, info->property_attributes());
+ Object* ok = SetPropertyCallback(name, info, info->property_attributes());
+    if (ok->IsFailure()) return ok;
   }

   return this;


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to