Reviewers: Vitaly, Dmitry Titov, Message: I'm looking for some initial comments on this one and expect that it will go through some revision.
And I think this is the right day, so: welcome back from vacation, Vitaly! Thanks Luke Description: [Isolates] Pass the current isolate to runtime functions. This is a first-draft patch; I'd like someone who is more familiar with the invariants inside the compiler to check it over. In particular, I'm not sure if I hit all of the places where a runtime stub could be called-- in an earlier revision where I was using cdecl for ia32, I ran into some strange "TypeError: number is not a function" exceptions. This problem no longer appears now that I pass the isolate in a register, but it still concerns me. On x64 and arm, I use the regular C calling convention (which in both cases allows me to pass the isolate pointer in a register). On ia32, I pass the isolate in ECX. Please review this at http://codereview.chromium.org/2884039/show SVN Base: http://v8.googlecode.com/svn/branches/experimental/isolates/ Affected files: M src/arguments.h M src/arm/codegen-arm.cc M src/assembler.h M src/assembler.cc M src/debug.h M src/debug.cc M src/func-name-inferrer.cc M src/handles.cc M src/heap.h M src/ia32/codegen-ia32.cc M src/ic.cc M src/jsregexp.cc M src/runtime.h M src/runtime.cc M src/serialize.cc M src/stub-cache.h M src/stub-cache.cc M src/x64/codegen-x64.cc M test/cctest/test-func-name-inference.cc -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
