LGTM
http://codereview.chromium.org/3029033/diff/8001/9003 File src/debug.cc (right): http://codereview.chromium.org/3029033/diff/8001/9003#newcode1304 src/debug.cc:1304: // to function it is goint to restart. function it -> the function which goint to -> going to be http://codereview.chromium.org/3029033/diff/8001/9003#newcode1311 src/debug.cc:1311: // If it's CallFunction stub ensure target function is compiled and flood This comment should be inside the else if body. http://codereview.chromium.org/3029033/diff/8001/9003#newcode1788 src/debug.cc:1788: thread_local_.restarter_frame_function_pointer_ = restarter_frame_function_pointer; Long line. http://codereview.chromium.org/3029033/diff/8001/9004 File src/debug.h (right): http://codereview.chromium.org/3029033/diff/8001/9004#newcode428 src/debug.h:428: // b. being compatible with regular stack structure for various stack iterators. Long line. http://codereview.chromium.org/3029033/diff/8001/9004#newcode429 src/debug.h:429: // Returns address of stack allocated pointer to restarted function, Stack allocated here means stored in the JavaScript stack? http://codereview.chromium.org/3029033/diff/8001/9004#newcode430 src/debug.h:430: // the value that is called 'restarter_frame_function_pointer'. Maybe mention where this return value is used. http://codereview.chromium.org/3029033/diff/8001/9004#newcode979 src/debug.h:979: return reinterpret_cast<Address>(Debug::restarter_frame_function_pointer_address()); Long line. http://codereview.chromium.org/3029033/diff/8001/9005 File src/ia32/debug-ia32.cc (right): http://codereview.chromium.org/3029033/diff/8001/9005#newcode299 src/ia32/debug-ia32.cc:299: Address fp = bottom_js_frame->fp(); Would it be possible to use some of the existing constants or (frames-ia32.h) here instead of 1, 2, 3, 4 and 5? Or possibly add more constants? http://codereview.chromium.org/3029033/diff/8001/9006 File src/liveedit.cc (right): http://codereview.chromium.org/3029033/diff/8001/9006#newcode1242 src/liveedit.cc:1242: *restarter_frame_function_pointer = Debug::SetUpFrameDropperFrame(bottom_js_frame, code); Long line. http://codereview.chromium.org/3029033/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
