http://codereview.chromium.org/2832095/diff/6001/7001 File src/platform-win32.cc (right):
http://codereview.chromium.org/2832095/diff/6001/7001#newcode846 src/platform-win32.cc:846: // TODO([email protected]): Port to x64 and Linux Please create an issue on code.google.com/p/v8 and change this TODO to TODO(issue number). http://codereview.chromium.org/2832095/diff/6001/7001#newcode846 src/platform-win32.cc:846: // TODO([email protected]): Port to x64 and Linux Please add a comment that for executable pages we try to randomize the allocation address. http://codereview.chromium.org/2832095/diff/6001/7001#newcode846 src/platform-win32.cc:846: // TODO([email protected]): Port to x64 and Linux To support x64 will it not just be a matter of having the constant 0x4FFF0000 in a intptr_t constant with a different constant on x64 controlled by V8_HOST_ARCH_64_BIT, see globals.h. If not please use a #ifdef V8_HOST_ARCH_64_BIT to use the original code for x64. http://codereview.chromium.org/2832095/diff/6001/7001#newcode847 src/platform-win32.cc:847: if (prot == PAGE_EXECUTE_READWRITE && I suggest you keep this condition on one line. http://codereview.chromium.org/2832095/diff/6001/7001#newcode854 src/platform-win32.cc:854: if (mbase == NULL && Condition on one line. http://codereview.chromium.org/2832095/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
