LGTM
http://codereview.chromium.org/3047038/diff/1/2 File src/parser.cc (right): http://codereview.chromium.org/3047038/diff/1/2#newcode3641 src/parser.cc:3641: #define CASE_KEYWORD(name, ignore1, ignore2) \ Please make a comment that all keywords fall through to string handling. http://codereview.chromium.org/3047038/diff/1/3 File src/runtime.cc (right): http://codereview.chromium.org/3047038/diff/1/3#newcode312 src/runtime.cc:312: // If key is a symbol that is not an array element. key -> the key that -> it but shouldn't the comment say that we know it is not an array index, as that has just been checked? http://codereview.chromium.org/3047038/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
