LG with the comparison issue addressed.
-- Vitaly http://codereview.chromium.org/3031005/diff/52001/53001 File src/accessors.cc (right): http://codereview.chromium.org/3031005/diff/52001/53001#newcode44 src/accessors.cc:44: if (obj == heap->null_value()) return NULL; Here and in lots of other places you're still using comparison to heap->null_value(). Even if there are no other heap usages around. Why can't these comparisons be replaced with obj->IsNull()? http://codereview.chromium.org/3031005/diff/52001/53014 File src/objects-inl.h (right): http://codereview.chromium.org/3031005/diff/52001/53014#newcode525 src/objects-inl.h:525: return IsOddball() && !(Oddball::cast(this)->kind() & Oddball::kBooleanMask); Use explicit "== 0" comparison. http://codereview.chromium.org/3031005/diff/52001/53016 File src/objects.h (right): http://codereview.chromium.org/3031005/diff/52001/53016#newcode4782 src/objects.h:4782: static const byte kBooleanMask = ~1; Boolean mask should be "1". "~1" is NotBoolean mask. http://codereview.chromium.org/3031005/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
