Thanks for the help, I'll resubmit it from bleeding_edge with proper bug relation and notifications to reviewers.
Burcu Dogan On Tue, Aug 3, 2010 at 11:48 AM, Vyacheslav Egorov <[email protected]>wrote: > And there is another small issue: better make patches against bleeding_edge > branch not against trunk (see > http://code.google.com/p/v8/wiki/Contributing#Getting_the_code). > > -- > Vyacheslav Egorov > > > > On Tue, Aug 3, 2010 at 10:42 AM, Søren Gjesse <[email protected]>wrote: > >> HI, >> >> I am not sure whether there actually is one. Usually I just put in >> >> BUG=http://code.google.com/p/v8/issues/detail?id=XXX >> >> instead of >> >> BUG=XXX >> >> Btw. please add a reviewer and send a review request from the review tool >> (or by using the -r and --send_mail options to gcl) when creating a patch. >> Otherwise the change might pass unnoticed. >> >> Regards, >> Søren >> >> On Mon, Aug 2, 2010 at 22:45, Burcu Dogan <[email protected]> wrote: >> >>> Hi, >>> >>> What's the prefix for V8 while filling the BUG=<prefix>:BUGNO on the >>> change details? I just created a new code review request, but its bug is >>> assigned to one of the chromium's older bugs. See it on >>> http://codereview.chromium.org/3080018 >>> >>> Thanks, >>> Burcu Dogan >>> >>> -- >>> v8-dev mailing list >>> [email protected] >>> http://groups.google.com/group/v8-dev >> >> >> -- >> v8-dev mailing list >> [email protected] >> http://groups.google.com/group/v8-dev >> > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
