I revised the patch to use cdecl on ia32. Please let me know what you think!
On 2010/08/02 14:33:38, Vitaly wrote:
AFAIR there are four types of functions that take Arguments:
1. Runtime functions (runtime.{h,cc})
2. C++ builtin functions (builtins.{h,cc})
3. IC utility functions (ic.{h,cc}: IC_UTIL_LIST macro)
4. Debug support functions (debug.{h,cc}).
All of these should be called using CEntryStub. They should have
identical C++
signatures.
I don't think we should use inline assembly on ia32 at this point. For now
let's
just get rid of the TLS read and standardize on (Isolate*, Arguments)
signature
(and cdecl calling convention on ia32). To help with possible future
changes
it
might make sense to wrap the runtime functions in macros like it's done
for
the
builtins.
-- Vitaly
http://codereview.chromium.org/2884039/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
