http://codereview.chromium.org/3030048/diff/1/3 File src/spaces.cc (right):
http://codereview.chromium.org/3030048/diff/1/3#newcode299 src/spaces.cc:299: capacity_rwx_ = RoundUp(capacity, Page::kPageSize); capacity_rwx_ = capacity_ to indicate that for now they are the same. Also I think this should be controlled through the API (SetResuourceConstraints) so that it is up to the embedder to constrain the amount of executable memory. Also information on the current size could be exposed through the GetHeapStatistics API. http://codereview.chromium.org/3030048/diff/1/3#newcode356 src/spaces.cc:356: LOG(StringEvent("MemoryAllocator::AllocateRawMemory", "V8 RWX Allocation capacity exceeded")); Long line. http://codereview.chromium.org/3030048/diff/1/3#newcode2611 src/spaces.cc:2611: // Clear the RWX flag before passing the size to MemoryAllocator::FreeRawMemory Long line and tabs. http://codereview.chromium.org/3030048/diff/1/3#newcode2613 src/spaces.cc:2613: // Issue 51241 is merged. Please don't have references to Chromium issues in the V8 source, only V8 issues. http://codereview.chromium.org/3030048/diff/1/3#newcode2794 src/spaces.cc:2794: Page* page = Page::FromAddress(RoundUp(current->address(), Page::kPageSize)); Long line. http://codereview.chromium.org/3030048/diff/1/4 File src/spaces.h (right): http://codereview.chromium.org/3030048/diff/1/4#newcode565 src/spaces.h:565: static void FreeRawMemory(void* buf, size_t length, bool executable); bool -> Executability http://codereview.chromium.org/3030048/diff/1/4#newcode633 src/spaces.h:633: // The mamimum RWX space size in bytes. mamimum -> maximum http://codereview.chromium.org/3030048/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
