http://codereview.chromium.org/3034060/diff/1/2
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/3034060/diff/1/2#newcode3312
src/arm/codegen-arm.cc:3312: literal = frame_->PopToRegister(r0);
Comment added.

http://codereview.chromium.org/3034060/diff/1/2#newcode3316
src/arm/codegen-arm.cc:3316: __ str(tmp, FieldMemOperand(r0, i));
Macro added. For now it just does the same, but with a larger overhead.

http://codereview.chromium.org/3034060/diff/1/2#newcode5347
src/arm/codegen-arm.cc:5347: Register tmp = r2;
Changed to scratch0/scratch1.

http://codereview.chromium.org/3034060/diff/1/2#newcode5350
src/arm/codegen-arm.cc:5350: Label done;
Added comment

http://codereview.chromium.org/3034060/diff/1/4
File src/arm/full-codegen-arm.cc (right):

http://codereview.chromium.org/3034060/diff/1/4#newcode1140
src/arm/full-codegen-arm.cc:1140: __ str(r2, FieldMemOperand(r0, i));
Too.

http://codereview.chromium.org/3034060/diff/1/14
File src/runtime.cc (right):

http://codereview.chromium.org/3034060/diff/1/14#newcode7600
src/runtime.cc:7600: RUNTIME_ASSERT(size <=
Heap::MaxObjectSizeInNewSpace());
Added constant for Heap::InitialSemiSpaceSize() * 3/4

http://codereview.chromium.org/3034060/diff/1/16
File src/string.js (right):

http://codereview.chromium.org/3034060/diff/1/16#newcode625
src/string.js:625: // Reuse lastIndex field for split limit when type is
"split".
Apparently we didn't hit it.

http://codereview.chromium.org/3034060/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to