Den 6. aug. 2010 19.15 skrev vlad <[email protected]>: > Hmmm, why it didnt work then... >
Sorry if I was being too subtle/snide. What I meant was that it could be that you spelled it wrong in the command line like you did in your email. > > I was about to submit very simple patch: > > Index: include/v8.h > =================================================================== > --- include/v8.h (revision 5191) > +++ include/v8.h (working copy) > @@ -919,6 +919,11 @@ > */ > V8EXPORT bool IsDate() const; > > + /** > + * Returns true if this value is a RegExp. > + */ > + V8EXPORT bool IsRegExp() const; > + > V8EXPORT Local<Boolean> ToBoolean() const; > V8EXPORT Local<Number> ToNumber() const; > V8EXPORT Local<String> ToString() const; > Index: AUTHORS > =================================================================== > --- AUTHORS (revision 5191) > +++ AUTHORS (working copy) > @@ -29,4 +29,4 @@ > Ryan Dahl <[email protected]> > Subrato K De <[email protected]> > Burcu Dogan <[email protected]> > - > +Vlad Burlik <[email protected]> > Index: src/api.cc > =================================================================== > --- src/api.cc (revision 5191) > +++ src/api.cc (working copy) > @@ -1792,6 +1792,13 @@ > } > > > +bool Value::IsRegExp() const { > + if (IsDeadCheck("v8::Value::IsRegExp()")) return false; > + i::Handle<i::Object> obj = Utils::OpenHandle(this); > + return obj->IsJSRegExp(); > +} > + > + > Local<String> Value::ToString() const { > if (IsDeadCheck("v8::Value::ToString()")) return Local<String>(); > LOG_API("ToString"); > > On Aug 6, 1:18 am, Erik Corry <[email protected]> wrote: > > Den 5. aug. 2010 23.53 skrev vlad <[email protected]>: > > > > > Hi, > > > Need a little help to submit code for review, but I'm getting an error > > > on 'gcl upload mychange' Here the steps: > > > > > - gcl change mychange > > > - gcl upload mychange. Enterring my gmail credentials > > > ... > > > urllib2.URLError: <urlopen error [Errno 10060] A connection attempt > > > failed because the connected party did not properly respond after a > > > period of time, or established connection failed because connected > > > host has failed to respond> > > > > > Do I need to use diff server instead of codereview.chrominum.org ? > > > > Yes, I think you need to use codereview.chromium.org > > > > -- > > Erik Corry, Software Engineer > > Google Denmark ApS. CVR nr. 28 86 69 84 > > c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen > K, > > Denmark. > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
