Great comments, thanks! Fixed all, except:
2. You can use OFFSET_OF (from globals.h) in its implementation (maybe modulo
a
friend declaration).
This indeed would require making Isoalte::heap_ public or making these bigclasses friends, neither is especially nice. Made it Heap::isolate() and used
C++ casts though. http://codereview.chromium.org/3089005/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
